Hi, On Sun, Dec 25, 2011 at 10:20 AM, Izumi Tsutsui <[email protected]> wrote: > Hi, > > Evgeniy Ivanov wrote: > >> Izumi, thank you for reviewing! New patches are attached. > : >> > I think it's better to use a positive LIBSA_ENABLE_LS_OP option rather >> > than LIBSA_NO_LS_OP, and make whole (fs_ops)->ls op part optional because >> > - there are many primary bootloaders (bootxx_foo) which don't need >> > the ls op and have size restrictions (alpha, atari, pmax ...) >> > - there are few bootloaders which support command prompt mode where >> > the `ls' op is actually required (some ports don't have even getchar()) >> >> Done. >> >> > We also have to check all other non-x86 bootloaders which refer ufs_ls(). >> > (ews4800mips, ia64, landisk, x68k, zaurus etc) >> >> Done. I'm not able to check though, but the modification is trivial >> and almost the same as for i386. > > Committed all changes (with several fixes for ews4800mips and x68k) > http://mail-index.NetBSD.org/source-changes/2011/12/25/msg029999.html
Great! > Thank you for your great work! np :-) > Now it's time for someone[TM] to try PR/30866 :-) > http://gnats.NetBSD.org/30866 Seems to be a useful feature, I'll work on this in Jan if it doesn't violate [TM] :P -- Evgeniy
