On Wed, Feb 3, 2010 at 9:41 AM, Owain Ainsworth <zer...@googlemail.com> wrote: >> Index: uvm_pager.c >> =================================================================== >> RCS file: /home/tedu/cvs/src/sys/uvm/uvm_pager.c,v >> retrieving revision 1.54 >> diff -u -r1.54 uvm_pager.c >> --- uvm_pager.c 22 Jul 2009 21:05:37 -0000 1.54 >> +++ uvm_pager.c 2 Feb 2010 04:23:57 -0000 >> @@ -138,7 +138,7 @@ >> { >> KASSERT(pseg->start == 0); >> KASSERT(pseg->use == 0); >> - pseg->start = uvm_km_valloc(kernel_map, MAX_PAGER_SEGS * MAXBSIZE); >> + pseg->start = uvm_km_valloc_try(kernel_map, MAX_PAGER_SEGS * MAXBSIZE); > > > this doesn't take into account the fact that valloc_try may fail and > return 0.
That appears to be the caller's concern. There's no difference in that regard between try and not try. (only do :)).