On Wed, Mar 03, 2010 at 02:59:23AM -0800, J.C. Roberts wrote:

> On Wed, 3 Mar 2010 11:36:28 +0100 Otto Moerbeek <[email protected]> wrote:
> 
> > > If fsck_ffs is *supposed* to read /etc/fstab like fsck does, then
> > > the problem is in the code.
> > 
> > fsck_ffs is not supposed to read fstab, so this line should be gone.
> > Diff below.
> > 
> > > 
> > > Also the `-p` option (preen) is not in the list of options.
> > 
> > Which list? usage and man page look ok to me on current.
> > 
> >     -Otto
> 
> The `-p` option is mentioned three times in two of the preceding
> paragraphs, but it is not listed in the main list of options e.g.:
> 
>       -b block#
>               bla bla
> 
>       -c level
>               bla bla
> 
>       ...
> 
> The preen mode `-p` option should still be in the main list of options
> as well as mentioned in the paragraphs. Since in fsck_ffs preen doesn't
> read /etc/fstab it's operation is slightly different than fsck proper.
> 
> -jcr

Right.

        -Otto

Index: fsck_ffs.8
===================================================================
RCS file: /cvs/src/sbin/fsck_ffs/fsck_ffs.8,v
retrieving revision 1.21
diff -u -p -r1.21 fsck_ffs.8
--- fsck_ffs.8  10 Jan 2010 10:53:33 -0000      1.21
+++ fsck_ffs.8  3 Mar 2010 11:08:43 -0000
@@ -195,6 +195,17 @@ which is assumed to be affirmative.
 File systems will not be opened for writing.
 This is the default for file systems to be checked that are
 concurrently mounted writable.
+.It Fl p
+Enter preen mode:
+.Nm
+will check all file systems listed on the command line
+and will make minor repairs without
+human intervention.
+Any major problems will cause
+.Nm
+to exit with a non-zero exit code,
+so as to alert any invoking program or script
+that human intervention is required.
 .It Fl y
 Assume a
 .Dq yes
@@ -218,12 +229,6 @@ are being converted at once.
 The format of a file system can be determined from the
 first line of output from
 .Xr dumpfs 8 .
-.Pp
-If no file systems are given to
-.Nm
-then a default list of file systems is read from
-the file
-.Pa /etc/fstab .
 .Pp
 Inconsistencies checked are as follows:
 .Pp

Reply via email to