On Wed, Apr 28, 2010 at 03:07:07AM +0300, Sviatoslav Chagaev wrote: > Not sure if this should be patched, since from what I understand, ioctl > never has direct parameters, but always only pointers? > Well, I didn't know that and I actually tried to pass an int, since > descriptions of other ioctl's of this dev explicitly state that a > pointer must be passed, but these said 'int'.
Yes, they also need a pointer to int. It's fixed now. Thanks for the patch. > Index: video.4 > =================================================================== > RCS file: /cvs/src/share/man/man4/video.4,v > retrieving revision 1.5 > diff -u -r1.5 video.4 > --- video.4 13 Sep 2008 05:37:12 -0000 1.5 > +++ video.4 27 Apr 2010 23:45:10 -0000 > @@ -100,7 +100,7 @@ > u_int32_t reserved[32]; > }; > .Ed > -.It VIDIOC_S_INPUT (int) > +.It VIDIOC_S_INPUT (int *) > Select the current video input. > .It VIDIOC_REQBUFS (struct v4l2_requestbuffers *) > Initiate memory mapping or user pointer I/O. > @@ -124,9 +124,9 @@ > Remove a buffer from the queue. > .Pp > Same structure as for VIDIOC_REQBUFS. > -.It VIDIOC_STREAMON (int) > +.It VIDIOC_STREAMON (int *) > Start video stream. > -.It Dv VIDIOC_STREAMOFF (int) > +.It Dv VIDIOC_STREAMOFF (int *) > Stop video stream. > .It VIDIOC_TRY_FMT (struct v4l2_format *) > Try a data format.
