On 2010/04/28 18:41, Luis Henriques wrote: > Anyway, this gave me the chance to find some more differences between > ath(4) and linux ath5k device driver. Two constants (HAL_MODE_11G and > HAL_MODE_XR) were defined with the wrong values. See updated patch > bellow.
hmm, I'm not sure about this... > --- sys/dev/ic/ar5xxx.h 20 Apr 2010 22:05:41 -0000 1.48 > +++ sys/dev/ic/ar5xxx.h 28 Apr 2010 17:33:17 -0000 > @@ -92,9 +92,9 @@ typedef enum { > HAL_MODE_TURBO = 0x002, > HAL_MODE_11B = 0x004, > HAL_MODE_PUREG = 0x008, > - HAL_MODE_11G = 0x010, > + HAL_MODE_11G = 0x080, > HAL_MODE_108G = 0x020, > - HAL_MODE_XR = 0x040, > + HAL_MODE_XR = 0x010, > HAL_MODE_ALL = 0xfff > } HAL_MODE; http://fxr.watson.org/fxr/source/dev/ath/ath_hal/ah.h has this: 410 #ifdef notdef 411 HAL_MODE_11G = 0x010, /* 11g channels (OFDM/CCK) */ 412 #else 413 HAL_MODE_11G = 0x008, /* XXX historical */ 414 #endif