> Date: Sat, 27 Nov 2010 14:02:36 +0001 > From: Jason McIntyre <j...@kerhand.co.uk> > > On Thu, Nov 25, 2010 at 07:47:37PM -0300, Carlos Alberto Pereira Gomes wrote: > > Hi, > > > > I know a one-character typo in a comment is not important, but here is > > the diff anyway: > > > > > > Index: lib/libc/stdlib/bsearch.c > > =================================================================== > > RCS file: /home/carlos/cvs/src/lib/libc/stdlib/bsearch.c,v > > retrieving revision 1.6 > > diff -u -r1.6 bsearch.c > > --- lib/libc/stdlib/bsearch.c 8 Aug 2005 08:05:36 -0000 1.6 > > +++ lib/libc/stdlib/bsearch.c 25 Nov 2010 22:15:49 -0000 > > @@ -37,7 +37,7 @@ > > * is odd, moving left simply involves halving lim: e.g., when lim > > * is 5 we look at item 2, so we change lim to 2 so that we will > > * look at items 0 & 1. If lim is even, the same applies. If lim > > - * is odd, moving right again involes halving lim, this time moving > > + * is odd, moving right again involves halving lim, this time moving > > * the base up one item past p: e.g., when lim is 5 we change base > > * to item 3 and make lim 2 so that we will look at items 3 and 4. > > * If lim is even, however, we have to shrink it by one before > > > > digging a bit further, i see also this: > > /usr/src/sys/arch/amd64/pci/agp_machdep.c: * dmamap_load since adding > coherency involes flags to the gtt pagetables. > /usr/src/sys/arch/i386/pci/agp_machdep.c: * dmamap_load since adding > coherency involes flags to the gtt pagetables. > > i suppose the intention here was "invokes", rather than "involves". i'll > fix all three if any developers care to confirm that.
I think it should be involves in all three cases, although the whole comment in agp_machdep.c is a bit insensible. We should probably ask oga to fix this, since he wrote it.
