On Sun, Dec 19, 2010 at 05:02:54AM +0200, Paul Irofti wrote: > On Sat, Dec 18, 2010 at 11:11:35PM +0000, Jacob Meuser wrote: > > this adds activate functions for drivers that don't have them. also > > add usbd_deactivate() in DVACT_DEACTIVATE for drivers that do have > > activate functions but don't have any dying flag. > > > > ok? > > About this interface, I looked around in the code and it seems to be > used mostly in activate functions and in failure cases inside attach. > > My question is if its not better to make usbd_deactivate() a function > similar to an activate() one. That way we can just add something like > ubdi_activate in the cfattach instead of a wrapper to it in each driver. ^^^^ That was supposed to be usbdi or usbd. 5am, probably time to go to bed.
> > I don't know what the plan is for usbd_deactivate thus what I'm > proposing might not make sense. Just a thought. > > Otherwise it would sure get rid of a lot of redundant code in dev/usb/*. > > usbd_set_dying(dev, flag)? Don't know.
