On Fri, Feb 11, 2011 at 07:34:41PM -0300, Gleydson Soares wrote: > plug a memleak in output_listing(); from NetBSD > Index: aicasm.c > =================================================================== > RCS file: /cvs/src/sys/dev/microcode/aic7xxx/aicasm.c,v > retrieving revision 1.14 > diff -u -r1.14 aicasm.c > --- aicasm.c 4 Oct 2005 23:46:14 -0000 1.14 > +++ aicasm.c 11 Feb 2011 22:24:44 -0000 > @@ -594,6 +594,7 @@ > if (isatty(fileno(stdin)) == 0) > putchar(input); > } > + free(func_values); > fprintf(stdout, "\nThanks!\n"); > } >
This is wrong. check_patch() is called later on with func_values as an argument. I think there is no point in trying to free this memory since the application is going to exit more or less soon. -- :wq Claudio
