On 03/03/11 2:20 PM, Claudio Jeker wrote:
On Wed, Mar 02, 2011 at 06:47:40PM -0500, Brad wrote:
Ethernet vlan(4) interfaces have valid Ethernet link layer
addresses but use a different interface type (IFT_L2VLAN vs
IFT_ETHER). Treat IFT_L2VLAN interfaces like IFT_ETHER
interfaces when handling link layer addresses.

 From FreeBSD


Index: ipv6cp.c
===================================================================
RCS file: /home/cvs/src/usr.sbin/ppp/ppp/ipv6cp.c,v
retrieving revision 1.10
diff -u -p -r1.10 ipv6cp.c
--- ipv6cp.c    7 Aug 2008 19:26:57 -0000       1.10
+++ ipv6cp.c    6 Feb 2011 07:29:30 -0000
@@ -148,6 +148,7 @@ SetInterfaceID(u_char *ifid, int userand
      switch(sdl->sdl_type) {
      case IFT_ETHER:
      case IFT_FDDI:
+    case IFT_L2VLAN:
        /* XXX need more cases? */
        break;
      default:


While theoretically correct it does not matter much becuase we do not have
any IFT_L2VLAN interfaces in OpenBSD and honestly I think we will never
have them either. IFT_L2VLAN should not have been defined in the first
place. If it acts like an IFT_ETHER it should be a IFT_ETHER :)

Anyway since there are other ppp code checking for this I think this is OK
as well.

Ah. I now see why that isn't the case. I was thinking sdl_type = if_type and for the most part that is true but not for VLAN ints.

--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Reply via email to