On Sun, Mar 13, 2011 at 8:49 AM, Stefan Sperling <s...@openbsd.org> wrote: > The vfwprintf.c innards are based on a mix of OpenBSD's vfprintf.c > and NetBSD's vfwprintf.c. In NetBSD, both narrow and wide character > versions are generated from the same file using tons of macro spaghetti. > I didn't find that very readable, so I've taken the time to expand all > the macros to their wide-character versions. This gives us a separate > vfwprintf.c file which differs from vfprintf.c only where necessary. > Below the actual diff (which mostly adds files) you'll find the diff > between vfprintf.c and vfwprintf.c for convenience.
The _SET_ORIENTATION() call in vswprintf.c should set the orientation to 1, not -1. (If you uncomment the "//X" lines in regress/lib/libc/orientation/orientation_test.c then it should catch this until you fix it.) Use FLOCKFILE/FUNLOCKFILE instead of flockfile/funlockfile in vfwprintf() > This will probably need a libc bump when it does in which isn't included > in this diff. Minor bump, yep. Philip Guenther
