On Sat, Apr 02, 2011 at 02:13:45PM +0200, Stefan Sperling wrote:
> Feel free to ack or reject these individually.
>
>
> Kill redundant offsetof definitions. All of these files include sys/param.h.
Those look fine.
> Index: in6.c
> ===================================================================
> RCS file: /cvs/src/sys/netinet6/in6.c,v
> retrieving revision 1.89
> diff -u -p -r1.89 in6.c
> --- in6.c 7 Oct 2010 22:07:06 -0000 1.89
> +++ in6.c 2 Apr 2011 12:02:04 -0000
> @@ -910,14 +910,7 @@ in6_update_ifa(struct ifnet *ifp, struct
> */
> if (ia == NULL) {
> hostIsNew = 1;
> - /*
> - * When in6_update_ifa() is called in a process of a received
> - * RA, it is called under an interrupt context. So, we should
> - * call malloc with M_NOWAIT.
> - */
> - ia = malloc(sizeof(*ia), M_IFADDR, M_NOWAIT | M_ZERO);
> - if (ia == NULL)
> - return (ENOBUFS);
> + ia = malloc(sizeof(*ia), M_IFADDR, M_WAITOK | M_ZERO);
This is a little bit suspect. But people who know the call path should
look at this.
typos look ok, but mah spjellingk is not vry good. (:
