On Mon, Apr 04, 2011 at 08:24:38PM +0200, Claudio Jeker wrote:
> On Mon, Apr 04, 2011 at 10:10:49AM -0700, Matthew Dempsky wrote:
> > On Mon, Apr 4, 2011 at 9:11 AM, Claudio Jeker <cje...@diehard.n-r-g.com>
> > wrote:
> > > + if (icmp_rediraccept == 0 || ipforwarding == 1)
> >
> > Would "ipforwarding != 0" be more appropriate here? According to
> > sysctl(3), ipforwarding == 2 is a legitimate configuration setting.
> >
>
> Yes, ipforwarding == 2 is legitimate but IMO it is not a full router when
> forwarding is only done when an IPsec flow is used. I have the feeling
> that IPsec may need some redirects. This is why I choosed the == 1 check.
add a comment to that effect; I had the same thought as matthew.
