No need to copy bugs@, tech@ and misc@. One is enough. I pick tech@. There a few size_t vs ssize_t inconsistencies but this looks very good for a start. I would suggest that as we are changing strtol and atoi calls that we take the opportunity to replace them with strtonum calls.
.... Ken On Sat, Apr 09, 2011 at 11:20:09AM -0400, Steven R. Gerber wrote: > Hi folks. > Current rdist will timeout with files >2GB, log as finished, but will > not die. > The bug (system/6586) was originally noted by IBM (AIX) in 2006: > https://www-304.ibm.com/support/docview.wss?uid=isg1IY85396 > I have patches for the client rdist and server rdistd. > I have tested i386 and amd64, in both directions. Please continue this. > Testing on alpha would be especially welcomed. > Thanks to everyone in advance. > > Steven > **************************************************************** > client.c > I did check into the comparison at line 689. Basically, it is ASSUMED > that link files (not the actual files) will be tiny. > The only attributes returned from an lstat() that refer to the symbolic > link itself are the file type (S_IFLNK), size, blocks, and link count > (always 1). > That code is safe FOR NOW ... > IF the (meta)data in the link grows a lot THEN it could be a problem. > > This should be a good state. > 1. FIXED bug of filesize >2GB -- calculations and messages > 2. FIXED similar in minimum freespace (and free files) > 3. verified/fixed system write (and read) calls > 4. TODO improve buffering > **************************************************************** > i386 -> i386 <install BIG file> OK > i386 -> i386 <BIG file already installed> OK > amd64 -> i386 <install BIG file> OK > amd64 -> i386 <BIG file already installed> OK > i386 -> amd64 <install BIG file> OK > i386 -> amd64 <BIG file already installed> OK > **************************************************************** > i386 -> macppc OK richardtoo...@paradise.net.nz > i386 -> amd64 OK richardtoo...@paradise.net.nz > macppc -> amd64 OK richardtoo...@paradise.net.nz > amd64 -> i386 OK richardtoo...@paradise.net.nz > **************************************************************** > ****************************************************************
