On Thu, May 05, 2011 at 08:09:16AM -0400, Kenneth R Westerback wrote: > On Thu, May 05, 2011 at 11:51:22AM +0100, Owain Ainsworth wrote: > > On Wed, May 04, 2011 at 11:59:52PM -0400, Kenneth R Westerback wrote: > > > And by using opendev(3) tunefs can accept disk UID's. > > > > > > Any actual tunefs(8) guru's out there who can explain what this > > > might break? > > > > > > Inspired by oga@'s work on atactl. > > > > millert already provided a diff for that, the the getpartition dance is > > necessary if you want to be able to provide partition names from fstab > > (say tunefs -N /home). This diff breaks that ability. > > Aha. I have no such ability here, since getfsfile() doesn't 'work' > for DUID entries in the fstab. :-) If I put back a 'real' device > name in my sacrificial entry I do see the millert version work > better than mine. > > Looking at that. > > .... Ken >
And looking closer I see I managed to misapply millert@'s version. Properly applied it does work fine. So ok krw@ on millert's diff. .... Ken
