On Wed, May 11, 2011 at 09:45:05AM +0300, Sviatoslav Chagaev wrote: > On Wed, 11 May 2011 03:35:56 +0000 > Jacob Meuser <[email protected]> wrote: > > > clipping is better than normalizing? really? > > Clipping might describe something like value&0xffffff, so no, not > clipping, saturating addition.
> > > + if (sum < ADATA_MIN) > > > + sum = ADATA_MIN; > > > + else if (sum > ADATA_MAX) > > > + sum = ADATA_MAX; http://en.wikipedia.org/wiki/Clipping_(audio) > Try it and see for yourself. it is like jackd, which I find annoying. I agree, changing volume of an active stream is annoying, but there is a reason for it. > > > > what about the case where aucat is used for offline mixing? > > > > What about it? it's a very different use case than the one you're trying to "fix". I'm asking you how your "fix" is going to affect that use case. > > like the mixerctl change, you are taking away things that exist > > for good reason, because it makes *your* situation better in *your* > > opinion, when you can (mostly) have what you want with the current > > code (if you just try a little). > > > > I'm not taking anything away, you most certainly are. whether or not you believe the code to be correct/useful is irrelevant, you are removing something. > I'm setting things right. lemme offer a suggestion. the next time you run into something that doesn't make any sense to you, check if someone else has already questioned it and if any reason has already been given. or at least ask why instead of asserting that it is wrong. that will get you more sympathy, from me anyway. -- [email protected] SDF Public Access UNIX System - http://sdf.lonestar.org
