On 05/12/11 10:21, Mark Lumsden wrote: > On Thu, May 12, 2011 at 09:06:44AM +0200, Alexander Hall wrote: >> On 05/12/11 07:30, Mark Lumsden wrote: >>> Hopefully one day adduser(8), will have "use warnings;" added to it. >> >> Looking at it, I'd rather see it shot in the head and buried. >> >> Well, maybe warnings and strict will in time force someone* to tidy it up. >> >> Also, I bet just about every 'local' in there should rather be 'my'. >> > > I'm pretty sure when I first started using OpenBSD (3.4), I added my first > user via adduser. Since then, when the need arises I just fire up adduser > and it does what it says on the tin. Apart from being caught out by that > damned "send message to user" and answering "yes" a dozen times, I've > never had a problem.
Well, I use it too, and find it userful, for non-automated user creation (staff etc). It was just the code that looked like a minor mess. :-) > There are mixed emotions about adduser, and when you look at the code you > understand why. I think I will try and clean it up a bit though. If there > are no objections. If the userfulness remains and the code looks fine we all win. :-) /Alexander > > And thanks for the ok. > > -mark
