On 2011/05/13 12:34, Otto Moerbeek wrote: > On Fri, May 13, 2011 at 12:29:22PM +0200, Mark Kettenis wrote: > > > > On Fri, May 13, 2011 at 11:39:01AM +0200, Mike Belopuhov wrote: > > > > > > > On Fri, May 13, 2011 at 11:26 AM, Mark Kettenis > > > > <mark.kette...@xs4all.nl> wrote: > > > > >> From: Vadim Zhukov <persg...@gmail.com> > > > > >> Date: Fri, 13 May 2011 13:10:10 +0400 > > > > >> > > > > >> Hello all. > > > > >> > > > > >> Looks like there is a typo in ioctl number... > > > > > > > > > > What makes you think this is a typo? > > > > > > > > > > > > > there are two ioctls with the same command number: > > > > > > > > #define BIOCDISCIPLINE _IOWR('B', 40, struct bioc_discipline) > > > > #define BIOCINSTALLBOOT _IOWR('B', 40, struct bioc_installboot) > > > > > > Only if the two structs happen to have the same size they will clash. > > > > It's still a bad idea to use the same command number. I believe we > > encode the size of the structure in there as a sanity check, not to > > extend the ioctl "namespace". > > I agree with that, so if the ABI change will not cause too many > troubles, it should be fixed.
It's only used by installboot, and only when installing a boot loader onto a softraid volume, so I think this is fairly safe. Side-note, BIOCINSTALLBOOT is missing from bio(4).