On Sun 2011.05.15 at 20:36 +0200, Thomas Pfaff wrote:
> A tiny oops done by someone cleaning up calmwm.h making cyclegroup and
> rcyclegroup behave the same.  The defines below are used as an argument
> to group_cycle as a boolean to decide if the groups should be cycled
> forward or backward, but now both values are true so it's always done
> in reverse.
> 
> Index: calmwm.h
> ===================================================================
> RCS file: /cvs/xenocara/app/cwm/calmwm.h,v
> retrieving revision 1.125
> diff -u -p -r1.125 calmwm.h
> --- calmwm.h  11 May 2011 13:53:51 -0000      1.125
> +++ calmwm.h  15 May 2011 16:26:23 -0000
> @@ -72,8 +72,8 @@
>  #define CWM_RCYCLE           0x0002
>  
>  /* group cycle */
> -#define CWM_CYCLEGROUP               0x0001
> -#define CWM_RCYCLEGROUP              0x0002
> +#define CWM_CYCLEGROUP               0x0000
> +#define CWM_RCYCLEGROUP              0x0001
>  
>  #define KBTOGROUP(X) ((X) - 1)

oops; heh, and client cycle uses CWM_{R,}CYCLE..

this should make it less ambiguous...

Index: calmwm.h
===================================================================
RCS file: /home/okan/hack/open/cvs/xenocara/app/cwm/calmwm.h,v
retrieving revision 1.125
diff -u -p -r1.125 calmwm.h
--- calmwm.h    11 May 2011 13:53:51 -0000      1.125
+++ calmwm.h    15 May 2011 17:17:23 -0000
@@ -68,12 +68,12 @@
 #define        CWM_EXEC_WM             0x0002
 
 /* client cycle */
-#define CWM_CYCLE              0x0001
-#define CWM_RCYCLE             0x0002
+#define CWM_CYCLE              0
+#define CWM_RCYCLE             1
 
 /* group cycle */
-#define CWM_CYCLEGROUP         0x0001
-#define CWM_RCYCLEGROUP                0x0002
+#define CWM_CYCLEGROUP         0
+#define CWM_RCYCLEGROUP                1
 
 #define KBTOGROUP(X) ((X) - 1)

Reply via email to