On Mon, Jun 20, 2011 at 01:54:38PM +0200, Mark Kettenis wrote:
> > Date: Mon, 20 Jun 2011 13:22:52 +0200 (CEST)
> > From: Mark Kettenis <mark.kette...@xs4all.nl>
> > 
> > > Date: Mon, 20 Jun 2011 11:04:24 +0200
> > > From: Mike Belopuhov <m...@crypt.org.ru>
> > > 
> > > hi,
> > > 
> > > the hibernate_machdep.c file depends on the acpi so it would be
> > > nice if we excluded this file if kernel config doesn't reference
> > > acpi. a simple fix that establishes the dependency is below. ok?
> > 
> > The hibernate code doesn't really depend on ACPI.  Currently it is
> > only called by the acpi code, but it should work just as well on
> > systems without ACPI.
> > 
> > The code should be !small_kernel though; it seems it is currently
> > wasting ramdisk space.
> 
> Turns out it isn't actually wasting space, or at least not a lot of
> it, since the whole file is wrapped in #ifndef SMALL_KERNEL.  We could
> still consider adding !small_kernel, since it will speed up building
> ramdisk kernels a bit.

Agreed, !small_kernel in the config is much nicer than wrapping the
whole file in an #ifndef.

If no one else does this i'll whip up the diff later today.

-0-
-- 
The sooner all the animals are dead, the sooner we'll find their money.
                -- Ed Bluestone, "The National Lampoon"

Reply via email to