On Fri, Jul 15, 2011 at 08:13:59PM -0300, Christiano F. Haesbaert wrote: > @@ -75,7 +76,8 @@ struct icmpstat { > { "rediraccept", CTLTYPE_INT }, \ > { "redirtimeout", CTLTYPE_INT }, \ > { "tstamprepl", CTLTYPE_INT }, \ > - { "stats", CTLTYPE_STRUCT } \ > + { "stats", CTLTYPE_STRUCT }, \ > + { "userecho", CTLTYPE_INT } \ > } > > #define ICMPCTL_VARS { \
Not to spin this thread off into arguing about style(9), but is there any reason for us to continue avoiding trailing commas in arrays like this? It's been valid since at least C89, there are plenty of places in the tree where we have them already, and using trailing commas could make a lot of -1/+2 diffs into simple +1 diffs (e.g., theo.c).