On Wed, Jul 04, 2012 at 04:19:43PM +0200, Mark Kettenis wrote:
> > Date: Wed, 4 Jul 2012 03:46:46 -0400
> > From: Brad Smith <b...@comstyle.com>
> > 
> > Recognize BCM5717C, BCM5719C and BCM5720C PHY.
> > 
> > ukphy2 at bge2 phy 3: Generic IEEE 802.3u media interface, rev. 0: OUI 
> > 0x00d897, model 0x0022
> > 
> > The rest came from FreeBSD.
> > 
> > 
> > Index: miidevs
> > ===================================================================
> > RCS file: /home/cvs/src/sys/dev/mii/miidevs,v
> > retrieving revision 1.117
> > diff -u -p -r1.117 miidevs
> > --- miidevs 19 Dec 2011 13:18:19 -0000      1.117
> > +++ miidevs 3 Jul 2012 04:11:50 -0000
> > @@ -159,7 +159,10 @@ model xxBROADCOM2 BCM5709C     0x003c  BCM570
> >  model xxBROADCOM2 BCM5761  0x003d  BCM5761 10/100/1000baseT PHY
> >  model xxBROADCOM2 BCM5709S 0x003f  BCM5709S 1000/2500baseSX PHY
> >  model xxBROADCOM3 BCM57780 0x0019  BCM57780 10/100/1000baseT PHY
> > +model xxBROADCOM3 BCM5717C 0x0020  BCM5717C 10/100/1000baseT PHY
> > +model xxBROADCOM3 BCM5719C 0x0022  BCM5719C 10/100/1000baseT PHY
> >  model xxBROADCOM3 BCM57765 0x0024  BCM57765 10/100/1000baseT PHY
> > +model xxBROADCOM3 BCM5720C 0x0036  BCM5720C 10/100/1000baseT PHY
> 
> If the numbers in the BCM5718 Programmer's Guide are correct, you've
> swapped the BCM5717C and BCM5720C entries.  Also, we really should
> keep these sorted in numerical order.

I asked yongari@freebsd for confirmation and he claims these are the
appropriate ids for BCM5717C and BCM5720C and he has sample boards.
Anyway I don't really care if you keep them as is or flip them around
since either way they're handled in the same manner. When we do see
BCM5720's showing up which they will be since HP/Dell/IBM are using
these dual-port chips its easy enough to flip them back (if necessary).

Regarding the sorting... well they are and grouped by each respective
OUI as the comment says relatively near the top of miidevs.
" * List of known models.  Grouped by oui."

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Reply via email to