> Date: Thu, 12 Jul 2012 19:48:33 +0300 > From: Paul Irofti <p...@irofti.net> > > This is a preparation diff making acpiec(4) global lock aware. > > Others will build on it when doing reads and writes. > > Okay?
Makes sense to me, except for: > Index: acpidev.h > =================================================================== > RCS file: /cvs/src/sys/dev/acpi/acpidev.h,v > retrieving revision 1.32 > diff -u -p -r1.32 acpidev.h > --- acpidev.h 6 Aug 2010 21:12:27 -0000 1.32 > +++ acpidev.h 12 Jul 2012 16:37:18 -0000 > @@ -332,6 +332,7 @@ struct acpiec_softc { > u_int32_t sc_gpe; > struct acpiec_event sc_events[ACPIEC_MAX_EVENTS]; > int sc_gotsci; > + char sc_glk; ..using char here is a bit weird. It won't save any space and it makes more sense to use int like we already do for sc_gotsci. With that change this is ok kettenis@