On 4.11.2012. 15:52, Brad Smith wrote: > On Sat, Nov 03, 2012 at 09:49:02PM +0000, Christian Weisgerber wrote: >> Like bge(4), we previously couldn't enable TCP/UDP transmit checksum >> offload on em(4). We can now. >> >> Works fine here on >> em0 at pci1 dev 1 function 0 "Intel PRO/1000MT (82540EM)" rev 0x02 >> and with VLAN on >> em0 at pci5 dev 0 function 0 "Intel PRO/1000 MT (82574L)" rev 0x00 >> >> Does anybody see any value in keeping the #ifdef around? > > Updated diff to disable with hw with known broken driver support. > >
Hello, it's working here. # ifconfig em0 hwfeatures em0: flags=28b43<UP,BROADCAST,RUNNING,PROMISC,ALLMULTI,SIMPLEX,MULTICAST,NOINET6> mtu 1500 hwfeatures=36<CSUM_TCPv4,CSUM_UDPv4,VLAN_MTU,VLAN_HWTAGGING> lladdr 00:1b:21:30:99:ba description: OUT_INT priority: 0 groups: egress media: Ethernet autoselect (1000baseT full-duplex,rxpause) status: active inet 193.198.155.10 netmask 0xfffffff0 broadcast 193.198.155.15 # ifconfig em1 hwfeatures em1: flags=28b43<UP,BROADCAST,RUNNING,PROMISC,ALLMULTI,SIMPLEX,MULTICAST,NOINET6> mtu 1500 hwfeatures=36<CSUM_TCPv4,CSUM_UDPv4,VLAN_MTU,VLAN_HWTAGGING> lladdr 00:1b:21:30:99:bb description: VLANS priority: 0 media: Ethernet autoselect (1000baseT full-duplex,rxpause) status: active # ifconfig em2 hwfeatures em2: flags=28843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST,NOINET6> mtu 1500 hwfeatures=36<CSUM_TCPv4,CSUM_UDPv4,VLAN_MTU,VLAN_HWTAGGING> lladdr 00:11:43:d1:ea:8c description: OSPF_INT priority: 0 media: Ethernet autoselect (1000baseT full-duplex,master,rxpause,txpause) status: active inet 10.1.1.1 netmask 0xfffffffc broadcast 10.1.1.3 # ifconfig em3 hwfeatures em3: flags=28843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST,NOINET6> mtu 1500 hwfeatures=36<CSUM_TCPv4,CSUM_UDPv4,VLAN_MTU,VLAN_HWTAGGING> lladdr 00:11:43:d1:ea:8d description: PFSYNC_INT priority: 0 media: Ethernet autoselect (1000baseT full-duplex,rxpause,txpause) status: active inet 10.244.244.1 netmask 0xfffffffc broadcast 10.244.244.3 # ifconfig vlan600 hwfeatures vlan600: flags=28943<UP,BROADCAST,RUNNING,PROMISC,SIMPLEX,MULTICAST,NOINET6> mtu 1500 hwfeatures=6<CSUM_TCPv4,CSUM_UDPv4> lladdr 00:1b:21:30:99:bb description: INT_IF priority: 0 vlan: 600 parent interface: em1 groups: vlan status: active inet 193.198.155.34 netmask 0xffffffe0 broadcast 193.198.155.63 # ifconfig carp0 hwfeatures carp0: flags=28843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST,NOINET6> mtu 1500 hwfeatures=6<CSUM_TCPv4,CSUM_UDPv4> lladdr 00:00:5e:00:01:01 priority: 0 carp: MASTER carpdev em0 vhid 1 advbase 1 advskew 10 carppeer 193.198.155.11 groups: carp status: master inet 193.198.155.12 netmask 0xffffffff # ifconfig carp1 hwfeatures carp1: flags=28843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST,NOINET6> mtu 1500 hwfeatures=6<CSUM_TCPv4,CSUM_UDPv4> lladdr 00:00:5e:00:01:02 priority: 0 carp: MASTER carpdev vlan600 vhid 2 advbase 1 advskew 10 carppeer 193.198.155.35 groups: carp status: master inet 193.198.155.33 netmask 0xffffffff OpenBSD 5.2-current (GENERIC.MP) #1: Mon Nov 5 14:29:48 CET 2012 r...@bcbnfw01.srce.hr:/usr/src/sys/arch/amd64/compile/GENERIC.MP real mem = 3219914752 (3070MB) avail mem = 3111780352 (2967MB) mainbus0 at root bios0 at mainbus0: SMBIOS rev. 2.3 @ 0xf9920 (87 entries) bios0: vendor Dell Computer Corporation version "A07" date 04/25/2008 bios0: Dell Computer Corporation PowerEdge 1850 acpi0 at bios0: rev 0 acpi0: sleep states S0 S4 S5 acpi0: tables DSDT FACP APIC SPCR HPET MCFG acpi0: wakeup devices PCI0(S5) PALO(S5) PBLO(S5) VPR0(S5) PBHI(S5) VPR1(S5) PICH(S5) acpitimer0 at acpi0: 3579545 Hz, 24 bits acpimadt0 at acpi0 addr 0xfee00000: PC-AT compat cpu0 at mainbus0: apid 0 (boot processor) cpu0: Intel(R) Xeon(TM) CPU 3.40GHz, 3391.96 MHz cpu0: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,DTES64,MWAIT,DS-CPL,EST,CNXT-ID,CX16,xTPR,NXE,LONG cpu0: 1MB 64b/line 8-way L2 cache cpu0: apic clock running at 199MHz cpu1 at mainbus0: apid 6 (application processor) cpu1: Intel(R) Xeon(TM) CPU 3.40GHz, 3391.51 MHz cpu1: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,DTES64,MWAIT,DS-CPL,EST,CNXT-ID,CX16,xTPR,NXE,LONG cpu1: 1MB 64b/line 8-way L2 cache ioapic0 at mainbus0: apid 7 pa 0xfec00000, version 20, 24 pins ioapic0: misconfigured as apic 0, remapped to apid 7 ioapic1 at mainbus0: apid 8 pa 0xfec80000, version 20, 24 pins ioapic1: misconfigured as apic 0, remapped to apid 8 ioapic2 at mainbus0: apid 9 pa 0xfec83000, version 20, 24 pins ioapic2: misconfigured as apic 0, remapped to apid 9 acpihpet0 at acpi0: 14318179 Hz acpimcfg0 at acpi0 addr 0xe0000000, bus 0-255 acpiprt0 at acpi0: bus 0 (PCI0) acpiprt1 at acpi0: bus 1 (PALO) acpiprt2 at acpi0: bus 3 (DOBA) acpiprt3 at acpi0: bus 2 (DOBB) acpiprt4 at acpi0: bus 4 (PBLO) acpiprt5 at acpi0: bus 8 (VPR0) acpiprt6 at acpi0: bus 5 (PBHI) acpiprt7 at acpi0: bus 6 (PXB1) acpiprt8 at acpi0: bus 7 (PXB2) acpiprt9 at acpi0: bus 9 (PICH) acpicpu0 at acpi0 acpicpu1 at acpi0 ipmi at mainbus0 not configured pci0 at mainbus0 bus 0 pchb0 at pci0 dev 0 function 0 "Intel E7520 Host" rev 0x09 ppb0 at pci0 dev 2 function 0 "Intel E7520 PCIE" rev 0x09 pci1 at ppb0 bus 1 ppb1 at pci1 dev 0 function 0 "Intel 6700PXH PCIE-PCIX" rev 0x09 pci2 at ppb1 bus 2 em0 at pci2 dev 11 function 0 "Intel PRO/1000MT (82546GB)" rev 0x03: apic 7 int 17, address 00:1b:21:30:99:ba em1 at pci2 dev 11 function 1 "Intel PRO/1000MT (82546GB)" rev 0x03: apic 7 int 18, address 00:1b:21:30:99:bb ppb2 at pci1 dev 0 function 2 "Intel 6700PXH PCIE-PCIX" rev 0x09 pci3 at ppb2 bus 3 mpi0 at pci3 dev 5 function 0 "Symbios Logic 53c1030" rev 0x08: msi scsibus0 at mpi0: 16 targets, initiator 7 sd0 at scsibus0 targ 0 lun 0: <SEAGATE, ST373307LC, DS09> SCSI3 0/direct fixed serial.SEAGATE_ST373307LC_3HZ9WFYH sd0: 70007MB, 512 bytes/sector, 143374650 sectors safte0 at scsibus0 targ 6 lun 0: <PE/PV, 1x2 SCSI BP, 1.0> SCSI2 3/processor fixed mpi0: target 0 Sync at 160MHz width 16bit offset 63 QAS 0 DT 1 IU 1 ppb3 at pci0 dev 4 function 0 "Intel E7520 PCIE" rev 0x09 pci4 at ppb3 bus 4 ppb4 at pci0 dev 5 function 0 "Intel E7520 PCIE" rev 0x09 pci5 at ppb4 bus 5 ppb5 at pci5 dev 0 function 0 "Intel 6700PXH PCIE-PCIX" rev 0x09 pci6 at ppb5 bus 6 em2 at pci6 dev 7 function 0 "Intel PRO/1000MT (82541GI)" rev 0x05: apic 9 int 0, address 00:11:43:d1:ea:8c ppb6 at pci5 dev 0 function 2 "Intel 6700PXH PCIE-PCIX" rev 0x09 pci7 at ppb6 bus 7 em3 at pci7 dev 8 function 0 "Intel PRO/1000MT (82541GI)" rev 0x05: apic 9 int 1, address 00:11:43:d1:ea:8d ppb7 at pci0 dev 6 function 0 "Intel E7520 PCIE" rev 0x09 pci8 at ppb7 bus 8 uhci0 at pci0 dev 29 function 0 "Intel 82801EB/ER USB" rev 0x02: apic 7 int 16 uhci1 at pci0 dev 29 function 1 "Intel 82801EB/ER USB" rev 0x02: apic 7 int 19 uhci2 at pci0 dev 29 function 2 "Intel 82801EB/ER USB" rev 0x02: apic 7 int 18 ehci0 at pci0 dev 29 function 7 "Intel 82801EB/ER USB2" rev 0x02: apic 7 int 23 usb0 at ehci0: USB revision 2.0 uhub0 at usb0 "Intel EHCI root hub" rev 2.00/1.00 addr 1 ppb8 at pci0 dev 30 function 0 "Intel 82801BA Hub-to-PCI" rev 0xc2 pci9 at ppb8 bus 9 vga1 at pci9 dev 13 function 0 "ATI Radeon VE" rev 0x00 wsdisplay0 at vga1 mux 1: console (80x25, vt100 emulation) wsdisplay0: screen 1-5 added (80x25, vt100 emulation) radeondrm0 at vga1: apic 7 int 18 drm0 at radeondrm0 pcib0 at pci0 dev 31 function 0 "Intel 82801EB/ER LPC" rev 0x02 pciide0 at pci0 dev 31 function 1 "Intel 82801EB/ER IDE" rev 0x02: DMA, channel 0 configured to compatibility, channel 1 configured to compatibility atapiscsi0 at pciide0 channel 0 drive 0 scsibus1 at atapiscsi0: 2 targets cd0 at scsibus1 targ 0 lun 0: <TEAC, CD-224E, K.9A> ATAPI 5/cdrom removable cd0(pciide0:0:0): using PIO mode 4, Ultra-DMA mode 2 pciide0: channel 1 disabled (no drives) usb1 at uhci0: USB revision 1.0 uhub1 at usb1 "Intel UHCI root hub" rev 1.00/1.00 addr 1 usb2 at uhci1: USB revision 1.0 uhub2 at usb2 "Intel UHCI root hub" rev 1.00/1.00 addr 1 usb3 at uhci2: USB revision 1.0 uhub3 at usb3 "Intel UHCI root hub" rev 1.00/1.00 addr 1 isa0 at pcib0 isadma0 at isa0 com0 at isa0 port 0x3f8/8 irq 4: ns16550a, 16 byte fifo pckbc0 at isa0 port 0x60/5 pckbd0 at pckbc0 (kbd slot) pckbc0: using irq 1 for kbd slot wskbd0 at pckbd0: console keyboard, using wsdisplay0 pcppi0 at isa0 port 0x61 spkr0 at pcppi0 fdc0 at isa0 port 0x3f0/6 irq 6 drq 2 fd0 at fdc0 drive 0: 1.44MB 80 cyl, 2 head, 18 sec mtrr: Pentium Pro MTRR support uhub4 at uhub0 port 3 "Dell product 0xa001" rev 2.00/0.00 addr 2 vscsi0 at root scsibus2 at vscsi0: 256 targets softraid0 at root scsibus3 at softraid0: 256 targets root on sd0a (e65f3df4ee83240b.a) swap on sd0b dump on sd0b carp0: state transition: BACKUP -> MASTER arp_rtrequest: bad gateway value carp1: state transition: BACKUP -> MASTER arp_rtrequest: bad gateway value