On Wed, Apr 03, 2013 at 08:17:27PM +0400, Vadim Zhukov wrote:
> Second iteration after input from halex@ (${...+} trick is cool!).

ok aja@ with nitpicks

Please sort the list this way:
start, stop, restart, reload, check

Please make the output this way:
rc_err "usage: $0 [-df] (${_allsup})"

i.e. {} -> () which is more standard imho

> Index: rc.subr
> ===================================================================
> RCS file: /cvs/src/etc/rc.d/rc.subr,v
> retrieving revision 1.68
> diff -u -p -r1.68 rc.subr
> --- rc.subr   19 Nov 2012 07:10:59 -0000      1.68
> +++ rc.subr   3 Apr 2013 15:50:32 -0000
> @@ -25,7 +25,12 @@ rc_err() {
>  }
>  
>  rc_usage() {
> -     rc_err "usage: $0 [-df] {start|check|reload|restart|stop}"
> +     local _a _allsup _enotsup
> +     for _a in start check reload restart stop; do
> +             eval _enotsup=\${rc_${_a}}
> +             [ X"${_enotsup}" != X"NO" ] && 
> _allsup="${_allsup+$_allsup|}${_a}"
> +     done
> +     rc_err "usage: $0 [-df] {${_allsup}}"
>  }
>  
>  rc_write_runfile() {
> 

-- 
Antoine

Reply via email to