On Mon, Apr 8, 2013 at 6:30 AM, Martin Pieuchot <mpieuc...@nolizard.org> wrote: > Diff below remove various external variable declaration from sources > files and move them to the corresponding header with an appropriate > comment if necessary. > > ok?
I like the idea. I agree with Alexey about copying forward the #ifdefs. ... > --- netinet/ip_icmp.c 18 Sep 2012 12:35:51 -0000 1.96 > +++ netinet/ip_icmp.c 8 Apr 2013 13:23:23 -0000 > @@ -125,6 +125,9 @@ void icmp_mtudisc_timeout(struct rtentry > int icmp_ratelimit(const struct in_addr *, const int, const int); > void icmp_redirect_timeout(struct rtentry *, struct rttimer *); > > +/* from ip_input.c */ > +extern u_char ip_protox[]; > + > extern struct protosw inetsw[]; No header file love for ip_protox and inetsw? (Ideally, IMO, the end result would only have 'extern' in top-level declarations in .h files) Philip Guenther
