On Sun, Apr 28, 2013 at 08:12:31AM -0500, Vladimir Támara Patiño wrote:
> reordering of #includes in setrunelocale.c to comply
> better with style (9).
>
> Index: locale/setrunelocale.c
> ===================================================================
> RCS file: /cvs/src/lib/libc/locale/setrunelocale.c,v
> retrieving revision 1.7
> diff -u -r1.7 setrunelocale.c
> --- locale/setrunelocale.c 5 Dec 2012 23:20:00 -0000 1.7
> +++ locale/setrunelocale.c 28 Apr 2013 13:10:49 -0000
> @@ -88,18 +88,20 @@
> * SUCH DAMAGE.
> */
>
> -#include "rune.h"
> #include <assert.h>
> #include <errno.h>
> #include <limits.h>
> +#include <locale.h>
> #include <paths.h>
> -#include <string.h>
> #include <stdio.h>
> #include <stdlib.h>
> #include <stddef.h>
> +#include <string.h>
> #include <unistd.h>
> -#include <locale.h>
> -#include <citrus/citrus_ctype.h>
> +
> +#include "citrus_ctype.h"
> +#include "citrus_ctype_local.h"
Looks good, but why are you adding citrus_ctype_local.h?
citrus_ctype_local.h is supposed to be private to the citrus/ directory.
So setrunelocale.c should not include it.
And since citrus_ctype_local.h is already included by citrus_ctype.h,
including it as you're proposing doesn't have any effect.
> +#include "rune.h"
> #include "rune_local.h"
>
> struct localetable {
