On Tue, Dec 03, 2013 at 06:48:11PM -0500, Brad Smith wrote:
> An unused function in the UVM code. #if 0 it out for now.
>
> uvm_map.c:171:14: error: unused function 'uvm_mapentry_freecmp'
> [-Werror,-Wunused-function]
> uvm_map.c:353:1: error: unused function 'uvm_mapentry_freecmp'
> [-Werror,-Wunused-function]
>
> OK?
>
>
> Index: uvm_map.c
> ===================================================================
> RCS file: /home/cvs/src/sys/uvm/uvm_map.c,v
> retrieving revision 1.163
> diff -u -p -r1.163 uvm_map.c
> --- uvm_map.c 21 Sep 2013 10:01:27 -0000 1.163
> +++ uvm_map.c 3 Dec 2013 23:27:50 -0000
> @@ -168,8 +168,10 @@ static __inline void uvm_mapent_copy(st
> struct vm_map_entry*);
> static int uvm_mapentry_addrcmp(struct vm_map_entry*,
> struct vm_map_entry*);
> +#if 0
> static int uvm_mapentry_freecmp(struct vm_map_entry*,
> struct vm_map_entry*);
> +#endif
> void uvm_mapent_free_insert(struct vm_map*,
> struct uvm_addr_state*, struct vm_map_entry*);
> void uvm_mapent_free_remove(struct vm_map*,
> @@ -349,12 +351,14 @@ uvm_mapentry_addrcmp(struct vm_map_entry
> * tree will be considered during 'any address' allocations.
> */
>
> +#if 0
> static __inline int
> uvm_mapentry_freecmp(struct vm_map_entry *e1, struct vm_map_entry *e2)
> {
> int cmp = e1->fspace < e2->fspace ? -1 : e1->fspace > e2->fspace;
> return cmp ? cmp : uvm_mapentry_addrcmp(e1, e2);
> }
> +#endif
>
> /*
> * Copy mapentry.
So which one will it be?
Index: uvm_map.c
===================================================================
RCS file: /home/cvs/src/sys/uvm/uvm_map.c,v
retrieving revision 1.163
diff -u -p -r1.163 uvm_map.c
--- uvm_map.c 21 Sep 2013 10:01:27 -0000 1.163
+++ uvm_map.c 7 Dec 2013 01:45:17 -0000
@@ -349,7 +349,7 @@ uvm_mapentry_addrcmp(struct vm_map_entry
* tree will be considered during 'any address' allocations.
*/
-static __inline int
+__unused static __inline int
uvm_mapentry_freecmp(struct vm_map_entry *e1, struct vm_map_entry *e2)
{
int cmp = e1->fspace < e2->fspace ? -1 : e1->fspace > e2->fspace;
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
