On Sun, Feb 09, 2014 at 01:51:19PM +0100, Benoit Lecocq wrote: > On 02/09/14 12:30, Mark Kettenis wrote: > >> Date: Sun, 09 Feb 2014 10:34:04 +0100 > >> From: Benoit Lecocq <b...@arcane-labs.net> > >> > >> On 02/08/14 23:34, Mark Kettenis wrote: > >>>> > >>>> Hi tech@, > >>>> > >>>> the diff below adds support for the Intel Centrino Wireless-N 2230 > >>>> card found in my Lenovo E330 to iwn(4). > >>>> > >>>> iwn0 at pci2 dev 0 function 0 "Intel Centrino Wireless-N 2230" rev 0xc4: > >>>> msi, MIMO 2T2R, BGN, address 60:6c:66:3b:ea:39 > >>>> > >>>> This is the 0x0888 version. > >>>> > >>>> I've got most changes from > >>>> https://github.com/seanbruno/freebsd-iwl/commit/53e6056c2df7355650abab77068943ac097a70c6#diff-7a5322b995ac8545b4f5d9096c3b5a5aR5445 > >>>> > >>>> which (i think) mostly landed in freebsd as part of > >>>> http://svnweb.freebsd.org/base?view=revision&revision=258035 > >>>> > >>>> This is the only iwn(4) device i have, so hopefully i did not broke > >>>> another supported device. > >>>> Any feedback and tests are welcome. > >>>> > >>>> Regards, > >>>> Fabian Raetz > >>> > >>> Hi Fabian, > >>> > >>> Finally had some time to look at this. I cleaned your diff up a bit. > >>> Also noticed that the sensitivy limits didn't match the Linux driver I > >>> was looking at. Does the diff below still result in working hardware > >>> for you? > >>> > >>> Thanks, > >>> > >>> Mark > >>> > >>> > >> > >> Hi, > >> > >> With your patch the network card is detected : > >> > >> iwn0 at pci3 dev 0 function 0 "Intel Centrino Wireless-N 2030" rev 0xc4: > >> msi, MIMO 2T2R, BGN, address 68:5d:43:20:8b:68 > >> > >> But I have the following message : > >> > >> iwn0: fatal firmware error > >> firmware error log: > >> error type = "UNKNOWN" (0x00001038) > >> program counter = 0x0002A698 > >> source line = 0x00001014 > >> error data = 0x0000000000001014 > >> branch link = 0x0002A5B40002A5B4 > >> interrupt link = 0x0000EC7A00000000 > >> time = 969333536 > >> driver status: > >> tx ring 0: qid=0 cur=6 queued=0 > >> tx ring 1: qid=1 cur=0 queued=0 > >> tx ring 2: qid=2 cur=0 queued=0 > >> tx ring 3: qid=3 cur=0 queued=0 > >> tx ring 4: qid=4 cur=36 queued=0 > >> tx ring 5: qid=5 cur=0 queued=0 > >> tx ring 6: qid=6 cur=0 queued=0 > >> tx ring 7: qid=7 cur=0 queued=0 > >> tx ring 8: qid=8 cur=0 queued=0 > >> tx ring 9: qid=9 cur=0 queued=0 > >> tx ring 10: qid=10 cur=0 queued=0 > >> tx ring 11: qid=11 cur=0 queued=0 > >> tx ring 12: qid=12 cur=0 queued=0 > >> tx ring 13: qid=13 cur=0 queued=0 > >> tx ring 14: qid=14 cur=0 queued=0 > >> tx ring 15: qid=15 cur=0 queued=0 > >> tx ring 16: qid=16 cur=0 queued=0 > >> tx ring 17: qid=17 cur=0 queued=0 > >> tx ring 18: qid=18 cur=0 queued=0 > >> tx ring 19: qid=19 cur=0 queued=0 > >> rx ring: cur=22 > >> 802.11 state 4 > >> > >> I have not the same issue with the patch from Fabian. > > > > Does the interface work despite this message? > > > > Does the following diff work better? > > > > Yes the interface work despite the message. > > Same messages with the new diff : > > iwn0: fatal firmware error > firmware error log: > error type = "UNKNOWN" (0x00001967) > program counter = 0x000099C4 > source line = 0x0000009F > error data = 0x000000FF00000013 > branch link = 0x000099BA000099BA > interrupt link = 0x0000EC7A00000000 > time = 254992438 > driver status: > tx ring 0: qid=0 cur=70 queued=0 > tx ring 1: qid=1 cur=0 queued=0 > tx ring 2: qid=2 cur=0 queued=0 > tx ring 3: qid=3 cur=0 queued=0 > tx ring 4: qid=4 cur=36 queued=0 > tx ring 5: qid=5 cur=0 queued=0 > tx ring 6: qid=6 cur=0 queued=0 > tx ring 7: qid=7 cur=0 queued=0 > tx ring 8: qid=8 cur=0 queued=0 > tx ring 9: qid=9 cur=0 queued=0 > tx ring 10: qid=10 cur=0 queued=0 > tx ring 11: qid=11 cur=0 queued=0 > tx ring 12: qid=12 cur=0 queued=0 > tx ring 13: qid=13 cur=0 queued=0 > tx ring 14: qid=14 cur=0 queued=0 > tx ring 15: qid=15 cur=0 queued=0 > tx ring 16: qid=16 cur=0 queued=0 > tx ring 17: qid=17 cur=0 queued=0 > tx ring 18: qid=18 cur=0 queued=0 > tx ring 19: qid=19 cur=0 queued=0 > rx ring: cur=22 > 802.11 state 4 > > Hi,
i'm seeing the firmware error too with both of your diffs and i'm pretty sure i fixed this firmware error in my last diff send to this thread by handling IWN_FW_TLV_SENS and IWN_FW_TLV_PHY_CALIB in iwn_read_firmware_tlv() Except the firmware error, the card is working fine. Regards, Fabian
