On 30 April 2014 16:55, Mark Kettenis <mark.kette...@xs4all.nl> wrote: >> From: Mike Belopuhov <m...@belopuhov.com> >> Date: Wed, 30 Apr 2014 16:00:45 +0200 >> >> On 30 April 2014 15:55, Mark Kettenis <mark.kette...@xs4all.nl> wrote: >> >> Date: Wed, 30 Apr 2014 15:38:39 +0200 (CEST) >> >> From: Mark Kettenis <mark.kette...@xs4all.nl> >> >> >> >> > Date: Wed, 30 Apr 2014 13:39:20 +0100 >> >> > From: Stuart Henderson <st...@openbsd.org> >> >> > >> >> > Seen when running e2fsprogs regression tests with /tmp on tmpfs >> >> >> >> I'm not surprised; tmpfs contains some serious bugs. I recommend not >> >> using it until those are fixed. >> > >> > Which means, I'd like somebody else besides espie@ to comment on my >> > uvm_aobj.c list manipulation hack diff. >> > >> >> Diff made sense to me when I looked at it, but I would rather hide >> direct pointer access :/ Perhaps LIST_SWAP does a tiny bit more, >> but it's cleaner and perhaps can be useful in the future. > > I'm not comfortable with introducing more <sys/queue.h> APIs. So > perhaps we should just punt on the optimization and remove/insert all > list items. Removing the trap comments that pedro set up... >
I agree.
