On 3 May 2014 20:29, Philip Guenther <[email protected]> wrote: > On Sat, May 3, 2014 at 12:40 PM, Chris Hettrick > <[email protected]>wrote: >> >> I was too ambitious with the previous diffs. Here they are again. >> First diff is whitespace only that can be checked with tr and md5. >> Second diff is for non-whitespace KNF cleanup. >> > > Uh, thanks, but bulk KNF diffs are really best done by the person > committing them. I mean, we love diffs, but if it's a bulk change, then > it's better to provide someone with the script used to make the change > instead of the raw diff, so that we don't have to verify that the diff is > just what it claims to be and can instead verify the process/algorithm. > Now, if we've done a KNF pass and missed something, please let us know, or > perhaps ping the person who did the KNF pass to see if it was intentional. > > (This is actually true of the entire OpenBSD tree: style is important, but > style < content.) > > For this particular diff, I see a mix of stuff I agree with (spaces around > assignment operators) and stuff I don't agree with and think are "out of > style", like the blank line removals and the unindentation of code in > braces after a 'case'. No way am I throwing that all in at once. > > > Philip Guenther
+1 .... Ken
