On Mon, May 05, 2014 at 11:12:00AM +1000, Joel Sing wrote:
> > - i = 0;
> > if (arg->count == 0) {
> > arg->count = 20;
> > - arg->data = (char **)malloc(sizeof(char *) * arg->count);
> > + arg->data = calloc(arg->count, sizeof(char *));
> > }
> > - for (i = 0; i < arg->count; i++)
> > - arg->data[i] = NULL;
>
> This one is a change in behaviour - if arg->count is > 0 then previously we
> zeroed arg->data; now we do not.
This one is calloc, not reallocarray, so unless I'm seriously missing
something obvious here, it is indeed zero'd, no?