Anybody is using the "-sa" modifier of route(8)?  A sockaddr in hexa,
really?  What's your use case? 

Otherwise, ok to kill it?

Index: keywords.h
===================================================================
RCS file: /home/ncvs/src/sbin/route/keywords.h,v
retrieving revision 1.28
diff -u -p -r1.28 keywords.h
--- keywords.h  22 Jan 2014 06:23:37 -0000      1.28
+++ keywords.h  22 Jul 2014 08:57:56 -0000
@@ -56,7 +56,6 @@ enum {
        K_REJECT,
        K_RTT,
        K_RTTVAR,
-       K_SA,
        K_SENDPIPE,
        K_SHOW,
        K_SSTHRESH,
@@ -113,7 +112,6 @@ struct keytab keywords[] = {
        { "reject",     K_REJECT },
        { "rtt",        K_RTT },
        { "rttvar",     K_RTTVAR },
-       { "sa", K_SA },
        { "sendpipe",   K_SENDPIPE },
        { "show",       K_SHOW },
        { "ssthresh",   K_SSTHRESH },
Index: route.8
===================================================================
RCS file: /home/ncvs/src/sbin/route/route.8,v
retrieving revision 1.73
diff -u -p -r1.73 route.8
--- route.8     26 Feb 2014 21:10:03 -0000      1.73
+++ route.8     22 Jul 2014 08:57:56 -0000
@@ -304,10 +304,6 @@ IPsec
 Hardware (link-level) addresses
 .It Fl mpls
 MPLS addresses
-.It Fl sa
-Actual
-.Vt sockaddr
-data, in hexadecimal format
 .El
 .Pp
 In the absence of modifiers, an address is assumed to be IPv4,
Index: route.c
===================================================================
RCS file: /home/ncvs/src/sbin/route/route.c,v
retrieving revision 1.168
diff -u -p -r1.168 route.c
--- route.c     23 Jun 2014 03:46:16 -0000      1.168
+++ route.c     22 Jul 2014 08:57:56 -0000
@@ -430,10 +430,6 @@ newroute(int argc, char **argv)
                                af = AF_INET6;
                                aflen = sizeof(struct sockaddr_in6);
                                break;
-                       case K_SA:
-                               af = PF_ROUTE;
-                               aflen = sizeof(union sockunion);
-                               break;
                        case K_MPLS:
                                af = AF_MPLS;
                                aflen = sizeof(struct sockaddr_mpls);
@@ -902,10 +898,7 @@ getaddr(int which, char *s, struct hoste
                return (1);
        case AF_MPLS:
                errx(1, "mpls labels require -in or -out switch");
-       case PF_ROUTE:
-               su->sa.sa_len = sizeof(*su);
-               sockaddr(s, &su->sa);
-               return (1);
+               /* NOTREACHED */
 
        case AF_INET:
                if (hpp != NULL)

Reply via email to