On Fri, Aug 29, 2014 at 11:25:52PM +0200, Alexander Bluhm wrote:
> I will try to pull parts of the diff into separate changes to make review
> easier.
Let's start with an obvious bug. Do not call free() on an array
in the data section. Fortunately the code was not reached. No
binary change.
ok?
bluhm
Index: usr.sbin/syslogd/syslogd.c
===================================================================
RCS file: /data/mirror/openbsd/cvs/src/usr.sbin/syslogd/syslogd.c,v
retrieving revision 1.119
diff -u -p -r1.119 syslogd.c
--- usr.sbin/syslogd/syslogd.c 25 Aug 2014 18:19:18 -0000 1.119
+++ usr.sbin/syslogd/syslogd.c 31 Aug 2014 20:00:14 -0000
@@ -646,7 +646,6 @@ main(int argc, char *argv[])
}
}
/* NOTREACHED */
- free(pfd);
return (0);
}
