On Fri, 12 Sep 2014 21:09:45 -0700, Doug Hogan wrote:
> Index: lib/libevent/event-internal.h
> ===================================================================
> RCS file: /cvs/src/lib/libevent/event-internal.h,v
> retrieving revision 1.6
> diff -u -p -r1.6 event-internal.h
> --- lib/libevent/event-internal.h 21 Apr 2010 20:02:40 -0000 1.6
> +++ lib/libevent/event-internal.h 13 Sep 2014 01:45:11 -0000
> @@ -78,7 +78,7 @@ struct event_base {
> #define TAILQ_NEXT(elm, field) ((elm)->field.tqe_next)
> #define TAILQ_FOREACH(var, head, field)
> \
> for((var) = TAILQ_FIRST(head); \
> - (var) != TAILQ_END(head); \
> + (var) != NULL; \
> (var) = TAILQ_NEXT(var, field))
> #define TAILQ_INSERT_BEFORE(listelm, elm, field) do {
> \
> (elm)->field.tqe_prev = (listelm)->field.tqe_prev; \
You should probably remove the definition of TAILQ_END above too.
All the others look OK. It looks like softraid in particular could
benefit from the use of the _SAFE foreach variants but if that is
done it should be in a separate diff.
- todd
