At the moment our re(4) driver will allow the reception of Jumbo frames
with chips that don't have support in the driver. Although I haven't
been able to reproduce this in theory it could be possible to cause
the kernel to crash with such hardware under the right conditions.

OK?


Index: re.c
===================================================================
RCS file: /home/cvs/src/sys/dev/ic/re.c,v
retrieving revision 1.149
diff -u -p -u -p -r1.149 re.c
--- re.c        13 Mar 2014 13:11:30 -0000      1.149
+++ re.c        19 Mar 2014 16:36:20 -0000
@@ -1900,8 +1919,12 @@ re_init(struct ifnet *ifp)
         * For 8169 gigE NICs, set the max allowed RX packet
         * size so we can receive jumbo frames.
         */
-       if (sc->sc_hwrev != RL_HWREV_8139CPLUS)
-               CSR_WRITE_2(sc, RL_MAXRXPKTLEN, 16383);
+       if (sc->sc_hwrev != RL_HWREV_8139CPLUS) {
+               if (sc->rl_flags & RL_FLAG_PCIE)
+                       CSR_WRITE_2(sc, RL_MAXRXPKTLEN, RE_RX_DESC_BUFLEN);
+               else
+                       CSR_WRITE_2(sc, RL_MAXRXPKTLEN, 16383);
+       }
 
        mii_mediachg(&sc->sc_mii);
 

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Reply via email to