Hello,

this diff makes spdmem(4) print out CAS latencies of DDR2 SDRAM DIMMs instead of "random garbage".

1) "i" is not "1"
2) CAS latency can be up to 7 (CL6 and CL7 DDR2 SDRAMs are common).

Regards,
David

Index: sys/dev/spdmem.c
===================================================================
RCS file: /cvs/src/sys/dev/spdmem.c,v
retrieving revision 1.4
diff -u -p -r1.4 spdmem.c
--- sys/dev/spdmem.c    19 Jan 2015 18:38:41 -0000      1.4
+++ sys/dev/spdmem.c    24 Jan 2015 22:28:37 -0000
@@ -533,8 +533,8 @@ spdmem_ddr2_decode(struct spdmem_softc *
        }

        /* Print CAS latency */
-       for (i = 5; i >= 2; i--) {
-               if (s->sm_data[SPDMEM_DDR_CAS] & (i << i)) {
+       for (i = 7; i >= 2; i--) {
+               if (s->sm_data[SPDMEM_DDR_CAS] & (1 << i)) {
                        printf("CL%d", i);
                        break;
                }

Reply via email to