Hi,

Revision 1.29 to usr.bin/telnet/sys_bsd.c breaks telnet for me.

The issue is that return is not sent when entering a password, when connected by telnet to a device[1]. The patch below [3] reverts the change and telnet then works again.

This change does not solve the problem [2] that brought this change about.

I will see if I can work out a fix that solves both problems.

Cheers

Fred

[1] Cisco CP7940G IP Phone

[2] http://marc.info/?l=openbsd-bugs&m=142168911530356&w=2

[3]
Index: sys_bsd.c
===================================================================
RCS file: /cvs/src/usr.bin/telnet/sys_bsd.c,v
retrieving revision 1.29
diff -u -p -u -r1.29 sys_bsd.c
--- sys_bsd.c   12 Feb 2015 09:50:50 -0000      1.29
+++ sys_bsd.c   21 Mar 2015 00:23:35 -0000
@@ -310,6 +310,7 @@ TerminalNewMode(int f)
        tmp_tc.c_lflag |= ICANON;
     } else {
        tmp_tc.c_lflag &= ~ICANON;
+       tmp_tc.c_iflag &= ~ICRNL;
        tmp_tc.c_cc[VMIN] = 1;
        tmp_tc.c_cc[VTIME] = 0;
     }

Reply via email to