On Sat, Mar 28, 2015 at 12:22:10AM -0400, Brian Callahan wrote: > Hi tech@ -- > > Noticed this yesterday reviewing brynet@'s vi diff. > We have the "appropriate" isblank(3) in ctype.h but the header > wasn't being included in all the files that used it so vi was > falling back to a #define in common/key.h for one set of files and > using isblank(3) from ctype.h in other files. > > This diff removes the #define from common/key.h and adds the header > to the .c files that need it. > > OK? > > ~Brian >
> -/* > - * Ex/vi commands are generally separated by whitespace characters. We > - * can't use the standard isspace(3) macro because it returns true for > - * characters like ^K in the ASCII character set. The 4.4BSD isblank(3) > - * macro does exactly what we want, but it's not portable yet. Well, isblank(3) is portable now.. so if anything, the comment is at least wrong. :-) ok brynet@