On Fri, May 08, 2015 at 11:23:22AM +0200, Gilles Chehade wrote: > On Thu, May 07, 2015 at 11:58:49AM +0200, Giovanni Bechis wrote: > > On Wed, May 06, 2015 at 09:33:02PM -0400, James Turner wrote: > > > So I'm not quite sure how to explain this but I'm getting similiar > > > emails to the one below and it seems like opensmtpd should be rejecting > > > them as they don't seem like they are a valid format. > > > > > > Have others seen emails like these? Should opensmtpd be rejecting them? > > > > > I can recreate those wrong formatted emails with this .forward file, I > > remember it worked when there was sendmail. > > Giovanni > > I could reproduce, I'll work on a fix right away >
Ok, issue understood. When delivering with mbox, we rely upon mail.local which adds the From delimiter unconditionally, this is code outside the smtpd scope. When delivering with other methods, we left it to the mda to decide if it had to be done or not, some did, others didn't (mda). Later, I was told that procmail was unhappy that we didn't prepend the >From header and that it would require custom config. I made changes to prepend it when delivering with the mda method, we observed no regress with different ones so it was committed. Now the problem is that if the .forward references a "|/path" it forks a mda (which prepends From), and if mda is sendmail then... it ends up calling mail.local which prepends From again. I think the proper fix is to reconsider the prepend in the mda case. If procmail requires custom config, so be it. Comments ? Ideas ? Opinions ? -- Gilles Chehade https://www.poolp.org @poolpOrg
