someone will hit this soon enough if they haven't already, but building
xerocara after recent import gave the following error:
/usr/xenocara/driver/xf86-video-mach64/src/atipreinit.c: In function
'ATIPreInit':
/usr/xenocara/driver/xf86-video-mach64/src/atipreinit.c:703: error:
'pInt10Info' undeclared (first use in this function)
/usr/xenocara/driver/xf86-video-mach64/src/atipreinit.c:703: error: (Each
undeclared identifier is reported only once
/usr/xenocara/driver/xf86-video-mach64/src/atipreinit.c:703: error: for each
function it appears in.)
*** Error 1 in driver/xf86-video-mach64/obj/src (Makefile:543 'atipreinit.lo')
*** Error 1 in driver/xf86-video-mach64/obj (Makefile:409 'install-recursive')
*** Error 1 in driver/xf86-video-mach64 (/usr/X11R6/share/mk/bsd.xorg.mk:196
'realinstall')
*** Error 1 in driver (<bsd.subdir.mk>:48 'realinstall')
*** Error 1 in . (<bsd.subdir.mk>:48 'realinstall')
*** Error 1 in /usr/xenocara (Makefile:116 'release-install')
pInt10Info is only in xenocara/driver/xf86-video-mach64/src/atipreinit.c,
and nowhere else in the tree.
if (pVBE && !(flags & PROBE_DETECT))
{
xf86Int10InfoPtr pInt10Info = pVBE->pInt10;
/* Validate, then make a private copy of, the initialised BIOS */
CARD8 *pBIOS = xf86int10Addr(pInt10Info, pInt10Info->BIOSseg << 4);
....
pInt10Info = NULL;
the last one doesn't seem to serve a purpose given that it is only used as
above to call a function. actually it doesn't look like that variable is
really needed at all.
i don't know what upstream is thinking, maybe a dev is already in contact,
so i'm not sure if i should even propose a diff at this point, but for
myself i just removed the last line.
--- driver/xf86-video-mach64/src/atipreinit.c.orig Tue May 26 08:45:39 2015
+++ driver/xf86-video-mach64/src/atipreinit.c Wed May 27 04:12:32 2015
@@ -700,7 +700,6 @@ ATIPreInit
#else
pATI->pVBE = pVBE;
pVBE = NULL;
- pInt10Info = NULL;
#endif /* TV_OUT */
if (ConfiguredMonitor && !(flags & PROBE_DETECT))
