On Wed, Jun 10, 2015 at 5:23 AM, Martin Pieuchot <m...@openbsd.org> wrote:
> On 02/06/15(Tue) 22:36, David Higgs wrote: > > Here are some new sensors for upd(4) devices. All exist on my device > except AtRateTimeToEmpty, which still seemed a logical addition given that > AtRateTimeToFull is already present. > > - AtRateTimeToEmpty > > - RunTimeToEmpty > > - NeedReplacement > > - Overload > > Nice. > > > If anyone had an AtRate sensor, it was probably producing meaningless > output. The relevant spec [0] indicates that these are in minutes, and my > device appears to be using seconds; the (previously unscaled) sensor value > expects nanoseconds! > > [0] http://www.usb.org/developers/hidpage/pdcv10.pdf > > > > And lastly, the NeedReplacement report has nothing to do with the System > Management Bus (SMB), so rename the constant. Nothing else in the tree > appears to use it, so hopefully this is safe. > > > > Feedback and lsusb -v output is welcome, as usual. > > Have you got any feedback from upd(4) users? > > Not as of yet. Theo reminded me that upd(4) usability needs to improve, so before I add any more sensors I will next be looking into man page updates and/or improved sensor status (e.g. WARN, CRITICAL) so that you need less configuration voodoo to get useful behavior out of sensorsd(8). Let me know if these new sensors should wait, in which case I can cut a separate diff for the other fixes and build upon that instead. --david
