> From: Alexey Suslikov <[email protected]> > Date: Sat, 5 Sep 2015 08:49:17 +0000 (UTC) > > Mark Kettenis <mark.kettenis <at> xs4all.nl> writes: > > > RCS file: /cvs/src/sys/kern/subr_pool.c,v > > <snip> > > > kd.kd_waitok = ISSET(flags, PR_WAITOK); > > <snip> > > > + /* > > + * XXX Until we can call msleep(9) without holding the kernel > > + * lock. > > + */ > > + if (ISSET(flags, PR_WAITOK)) > > It there a reason to re-evaluate ISSET while it is already de-normalized > into kd.kd_waitok?
I think my reasoning was that the compilermight have an easier job optimizing this as kd.nowait is part of a struct that is passed to km_alloc(). Don't think this will matter, and I hope this code will go away soon anyway.
