memset() -> explicit_bzero() in login_yubikey(8)

[Michael McConville]

Does this look right?


Index: login_yubikey.c
===================================================================
RCS file: /cvs/src/libexec/login_yubikey/login_yubikey.c,v
retrieving revision 1.10
diff -u -p -r1.10 login_yubikey.c
--- login_yubikey.c     16 Jan 2015 06:39:50 -0000      1.10
+++ login_yubikey.c     10 Sep 2015 17:05:02 -0000
@@ -152,7 +152,7 @@ main(int argc, char *argv[])
        }
 
        ret = yubikey_login(username, password);
-       memset(password, 0, strlen(password));
+       explicit_bzero(password, strlen(password));
        if (ret == AUTH_OK) {
                syslog(LOG_INFO, "user %s: authorize", username);
                fprintf(f, "%s\n", BI_AUTH);