On Fri, Sep 18, 2015 at 11:05:55PM +0200, Vincent Gross wrote: > On 09/18/15 15:18, David Hill wrote: > > Is this 'if (count)' statement needed? We know first > last, so count > > will always be positive. lastport will always be set. > > > if last == first, then the if statement will be false and lastport will > > be uninitialized, I believe. > > > > Both remarks are true, but I think it is better to keep a more extensive > refactoring in a separate diff, refactoring that shall get rid of this > yucky code duplication. >
Well, this code changes the current behavior. I'd at least change lastport to be initialized to 0 to keep the behavior the same. It was previously set to 0 with M_ZERO. > -- > Vincent Gross >
