> Date: Mon, 12 Oct 2015 11:16:27 +0200 > From: Stefan Sperling <[email protected]> > > On Sun, Oct 11, 2015 at 09:02:27PM +0200, Mark Kettenis wrote: > > Using dma_alloc() here would be wrong. Drivers should use > > bus_dmamem_alloc(). > > Thanks, noted. > > Do you think iwm should use a buffer allocated with bus_dmamem_alloc() > here, or stick with the mbuf?
Don't really have an opinion about that. It seems there is existing infrastructure that uses mbufs for firmware commands, so it might indeed make sense to use that infrastructure, especially if using bus_dmamem_alloc() requires you to add additional code.
