On Tue, Nov 03, 2015 at 09:40:38PM +0100, Alexandr Nedvedicky wrote:
> I think the
> right thing is to use goto _skip; in that branch to avoid 499 et. al.
> completely.
Yes
> @@ -491,6 +491,7 @@ pfr_set_addrs(struct pfr_table *tbl, str
> if (pfr_route_kentry(tmpkt, p)) {
> pfr_destroy_kentry(p);
> ad.pfra_fback = PFR_FB_NONE;
> + goto _skip;
> } else {
> SLIST_INSERT_HEAD(&addq, p, pfrke_workq);
> ad.pfra_fback = PFR_FB_ADDED;
I would prefer not to have an else block after a goto. You can
remove the else and move the tree following lines one tab to the
left.
anyway OK bluhm@
