Re: libc asr _res.nsaddr_list overflow

[Alexander Bluhm]

Looks like I have fogotten to update the name server counter
correctly.

ok?

bluhm

Index: lib/libc/asr/res_init.c
===================================================================
RCS file: /data/mirror/openbsd/cvs/src/lib/libc/asr/res_init.c,v
retrieving revision 1.7
diff -u -p -U4 -r1.7 res_init.c
--- lib/libc/asr/res_init.c     5 Nov 2015 22:44:37 -0000       1.7
+++ lib/libc/asr/res_init.c     5 Nov 2015 23:01:55 -0000
@@ -56,17 +56,17 @@ res_init(void)
                        _res.options = ac->ac_options;
                if (_res.lookups[0] == '\0')
                        strlcpy(_res.lookups, ac->ac_db, sizeof(_res.lookups));
 
-               _res.nscount = ac->ac_nscount;
                for (i = 0, j = 0; i < ac->ac_nscount && j < MAXNS; i++) {
                        if (ac->ac_ns[i]->sa_family != AF_INET ||
                            ac->ac_ns[i]->sa_len > sizeof(_res.nsaddr_list[j]))
                                continue;
                        memcpy(&_res.nsaddr_list[j], ac->ac_ns[i],
                            ac->ac_ns[i]->sa_len);
                        j++;
                }
+               _res.nscount = j;
                _res.options |= RES_INIT;
        }
        _THREAD_PRIVATE_MUTEX_UNLOCK(init);