Tobias Stoeckmann wrote:
> Opinions, thoughts?
looks good, but you've got some mostly unrelated changes in here. this should
be separate, but ok for the rest.
> > Index: sbin/newfs_ext2fs/newfs_ext2fs.c
> > ===================================================================
> > RCS file: /cvs/src/sbin/newfs_ext2fs/newfs_ext2fs.c,v
> > retrieving revision 1.17
> > diff -u -p -u -p -r1.17 newfs_ext2fs.c
> > --- sbin/newfs_ext2fs/newfs_ext2fs.c 14 Oct 2015 15:54:49 -0000
> > 1.17
> > +++ sbin/newfs_ext2fs/newfs_ext2fs.c 7 Nov 2015 11:16:27 -0000
> > @@ -519,7 +519,8 @@ getpartition(int fsi, const char *specia
> > if (!S_ISCHR(st.st_mode))
> > warnx("%s: not a character-special device", special);
> > cp = strchr(argv[0], '\0') - 1;
> > - if (cp == NULL || ((*cp < 'a' || *cp > ('a' + getmaxpartitions() - 1))
> > + if (cp == NULL || cp < argv[0] ||
> > + ((*cp < 'a' || *cp > ('a' + getmaxpartitions() - 1))
> > && !isdigit((unsigned char)*cp)))
> > errx(EXIT_FAILURE, "%s: can't figure out file system
> > partition", argv[0]);
> > lp = getdisklabel(special, fsi);
