Mathieu - wrote: > Mathieu - wrote: > > > > Hello, > > > > Martin Pieuchot wrote: > > > Hello, > > > > > > On 07/12/15(Mon) 16:48, Mathieu - wrote: > > > > Hello, > > > > > > > > I worked a bit on umass(4) recently and had a diff to pass the > > > > umassbus_softc's real size to free so here it is. At some point I > > > > pondered about deleting the whole abstraction, as it would simplify the > > > > free'ing, for we only have one implementation (umass_scsi_softc, as > > > > atapi > > > > uses it too). But I figured it would be against the whole design of the > > > > umass driver, thoughts? > > > > > > I'd rather create a umass_scsi_detach() function symmetrical to > > > umass_scsi_attach(). This way you don't need an extra variable > > > for the size, keep the autoconf(9) glue inside umass_scsi.c and > > > can turn "struct umassbus_softc" into an opaque type. > > > > Please find a patch implementing the suggested approach below. > > Oups I left a debugging printf in there. Here is the clean patch, sorry > again for the noise.
Anyone?
