On Wed, 13 Jan 2016, Theo de Raadt wrote: > - tp->t_ispeed = tp->t_ospeed = TTYDEF_SPEED; > + tp->t_ispeed = tp->t_ospeed = 1000000; > > I don't think that is the right thing to do, without some testing. > That is directly visible in the program running on the pty. Some > programs make decisions based upon baud rate, but what worries me here > is this doesn't match one of the Bxxxxx standard speeds. Some legacy > ports programs may still expect that speeds need to match those. > > Can pty memory allocation behaviour be kept independent of this? > > Certainly I wouldn't mind if that is set to B115200. >
The memory allocation is independent of this, but ttsetwater() looks at the t_ospeed for calculating the lo/hi watermarks. But with the current implementation and the buffer sizes from the patch, t_ospeed = 1000000 and t_ospeed = B115200 give the same watermarks. So B115200 is just as good.
